Store segment alignment as a power of 2, and bump metadata version to 2 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an ABI break so bump the metadata version to 2
|
I think we've promised so far that the ABI is not stable, so we can probably just continue to call this ABI version 1? |
|
I'd link to bump it anyway, just for completeness. And to see what it looks like to actual do the bump. |
|
I think whenever we do do a bump we should also make it clear in the repo versioning (e.g. put it in the commit summary, maybe a git tag too) so it's easy to find the spec for previous revisions in the history. |
dschuff
approved these changes
Jan 16, 2019
|
let's go ahead and get this in now to ensure it makes the branch. |
sbc100
changed the title
llvm-git-migration
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Jan 16, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 llvm-svn: 351285
bogner
pushed a commit
to bogner/llvm-zipper-prototype
that referenced
this pull request
Jan 16, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8
llvm-git-migration
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Jan 16, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56762 llvm-svn: 351287
dtzWill
pushed a commit
to llvm-mirror/lld
that referenced
this pull request
Jan 16, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56762 git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@351287 91177308-0d34-0410-b5e6-96231b3b80d8
earl
pushed a commit
to earl/llvm-mirror
that referenced
this pull request
Jan 16, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8
dylanmckay
pushed a commit
to dylanmckay/llvm
that referenced
this pull request
Jan 20, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8
zhuowei
pushed a commit
to swiftwasm/swift-llvm
that referenced
this pull request
Apr 13, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8 (cherry picked from commit 29aeb33)
zhuowei
pushed a commit
to swiftwasm/swift-llvm
that referenced
this pull request
Apr 15, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8 (cherry picked from commit 29aeb33)
zhuowei
pushed a commit
to swiftwasm/swift-llvm
that referenced
this pull request
May 2, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8 (cherry picked from commit 29aeb33)
zhuowei
pushed a commit
to swiftwasm/swift-llvm
that referenced
this pull request
Jun 9, 2019
This change bumps for version number of the wasm object file metadata. See WebAssembly/tool-conventions#92 Differential Revision: https://reviews.llvm.org/D56758 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@351285 91177308-0d34-0410-b5e6-96231b3b80d8 (cherry picked from commit 29aeb33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ABI break so bump the metadata version to 2