Enabled merged proposals by default #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables three proposals by default since they've been merged into the upstream specification: * `saturating-float-to-int` - WebAssembly/spec#1143 * `sign-extension` - WebAssembly/spec#1144 * `multi-value` - WebAssembly/spec#1145 Most of the fallout from this is in the test suite with lots of `--enable` flags getting removed and some tests which now unconditionally pass also getting removed. Two spec tests explicitly pass `--disable` until the spec test submodule is updated.
binji
approved these changes
May 6, 2020
There was a problem hiding this comment.
Thanks, lgtm! I was initially a little concerned about removing these tests, since I imagine folks will still want to test against MVP for a while. That said, I figure a better solution for that would be to keep a collection of MVP tests instead of maintaining them in wabt. So I'm OK with removing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables three proposals by default since they've been merged into
the upstream specification:
saturating-float-to-int- Merge nontrapping-float-to-int proposal into spec spec#1143sign-extension- Merge sign-extension-ops proposal into spec spec#1144multi-value- Merge multi-value proposal into spec spec#1145Most of the fallout from this is in the test suite with lots of
--enableflags getting removed and some tests which nowunconditionally pass also getting removed. Two spec tests explicitly
pass
--disableuntil the spec test submodule is updated.