Skip to content

emmalloc: use __heap_end instead of sbrk(0) #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

emmalloc: use __heap_end instead of sbrk(0) #462

merged 1 commit into from
Jan 10, 2024

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Jan 10, 2024

This synchronizes emmalloc with the dlmalloc changes in #377 and #394.

@cuviper
Copy link
Contributor Author

cuviper commented Jan 10, 2024

This is an alternative to #378, and more current since __heap_end was made mandatory in #394. I had suggested changes in that other PR a few months ago, but never heard back.

sunfishcode
sunfishcode approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit 03b228e into WebAssembly:main Jan 10, 2024
toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Jan 21, 2024
@toyobayashi
emmalloc: use __heap_end instead of sbrk(0) (WebAssembly/wasi-libc#462)
c983643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuviper @sunfishcode