Skip to content

implement getsockname, getpeername, and getaddrinfo #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Mar 28, 2024

This also includes stubs for gethostbyname, gethostbyaddr, etc. which were necessary to get CPython to build. I believe it will be possible to implement them all properly at some point, but don't have the bandwidth at the moment.

Finally, this includes a few fixes for issues I missed in earlier PRs that surfaced when running the CPython asyncio test suite.

This also includes stubs for `gethostbyname`, `gethostbyaddr`, etc. which were
necessary to get CPython to build.  I believe it will be possible to implement
them all properly at some point, but don't have the bandwidth at the moment.

Finally, this includes a few fixes for issues I missed in earlier PRs that
surfaced when running the CPython `asyncio` test suite.

Signed-off-by: Joel Dice <[email protected]>
Co-authored-by: Dave Bakker <[email protected]>
Signed-off-by: Joel Dice <[email protected]>
@abrown
Copy link
Collaborator

abrown commented Aug 27, 2024

Looking at this again, did we mean to expose the tcp|udp_get* functions as defined symbols (e.g., tcp_getpeername)? cc: @dicej

@dicej
Copy link
Contributor Author

dicej commented Aug 28, 2024

@abrown It depends on what you mean by "expose". Everything's exposed due to -fvisibility=default here and will presumably remain that way until we start annotating deliberately-exported functions with explicit visibility (at which point we can stop using -fvisibility=default). Those functions aren't in any public header file, though, so they're not exposed in that sense AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants