AT_FDCWD support #54
Closed
AT_FDCWD support #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looking good! |
|
Ok, I think this is in pretty good shape now. |
Include the headers for the types that it uses, and add warn_unused_result annotations to its functions.
And add __warn_unused_result__ to other functions in libc.h while here.
This skips going through unnecessary wrapper layers.
This doesn't need to conform exactly to openat's signature, so don't use varargs, which is emulated on wasm.
|
This will need to be revised in terms of #214. |
Merged
|
An updated version of this patch is now at #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
AT_FDCWD, as well as absolute paths in*atfunctions, following the scheme described here.This is a relatively elaborate change, and is not at all tested yet, so I'm inclined to take some time here to think this through.
Fixes #42.