Install additional LLVM tools. #68
Conversation
This installs unqualified `nm`, `ar`, and other symlinks, additional tools including `llvm-objdump` and `llvm-objcopy`, and additional clang tools such as `clang-format` and `clang-tidy`.
|
We can do one any time. I'm interested in getting WebAssembly/wasi-libc#112 and a few related PRs into a release, but we don't need to block on that if you want to do something sooner. |
|
ok, lets wait for that one and then do a release. |
| install-objdump \ | ||
| install-objcopy \ | ||
| install-c++filt \ | ||
| llvm-config |
There was a problem hiding this comment.
At some point it probably makes sense just install the whole of llvm (not the devel parts but the user parts) rather than trying maintain this long whitelist?
If space saving are what we are after a better approach would probably be to use LLVM_LINK_LLVM_DYLIB to avoid duplication between all the binaries? (This relies on -Wl,-rpath on linux .. so maybe there windows/mac portability issies?, but other investigating).
There was a problem hiding this comment.
If there's a rule to install all the user parts, I'd be happy to switch to it.
And yeah, LLVM_LINK_LLVM_DYLIB is nice, but we should investigate its portability first.
| install-clang-format \ | ||
| install-clang-tidy \ | ||
| install-clangQuery \ | ||
| install-clang-apply-replacements \ |
There was a problem hiding this comment.
Do all of these targets existing llvm 8 too? Do want want to continue to support llvm-8?
There was a problem hiding this comment.
I haven't tested a full build, but they're all present in the llvm 8 source tree.
My understanding is that these dummy libs represent libraries who's contents, under musl, live in libc itself rather than being split out into separate libs. libc++/libc++abi are not provided my musl so doesn't make sense to pretend that we provide them.
This installs unqualified
nm,ar, and other symlinks, additionaltools including
llvm-objdumpandllvm-objcopy, and additional clangtools such as
clang-formatandclang-tidy.