Fixes for maximum stage complexity calculation #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-motionmark-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps to address an issue with scoring when tests reach the maximum complexity that a story supports. Currently this only applies to the "Multiply" test among the mainline tests.
For the following screenshots, I've artificially limited the "Multiply" test's totalRows to 10 (for a maximum stage complexity of 135) highlight this issue.
When a test reaches the maximum stage complexity, the controller can try to test a much higher complexity than the stage supports, since the code estimating the maximum complexity isn't aware of the stage's limit. This is particularly an issue for the Slope Profile, which has a harder time calculating the score when all samples are basically in a flat line.
Before
Slope Profile
After
Slope Profile
Note: the Slope score being less than 135 in the "After" picture isn't because of this change. The Slope regression is hit & miss either way, but is generally more predictable after this change. The Mean ramp score is pretty noisy with the Slope function as we can see.
Windowed Strict Profile
For the Windowed Strict profile, the score is generally more accurate with or without this change.