-
-
Notifications
You must be signed in to change notification settings - Fork 248
Add Assassin's Creed: Unity's Forge files and Data files (Compressed and Decompressed) #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hex Pattern file for Capcom's Devil May Cry 3 HD Collection's .mod (3D Models) files
@@ -0,0 +1,49 @@ | |||
#pragma description Assassin's Creed: Unity's Compressed .data file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all of these files are are related to Assassin's Creed, I think it would make sense to put them all in a subfolder (like the Final Fantasy ones). Maybe under patterns/ac_unity
or something similar
patterns/acu_data_compressed.hexpat
Outdated
#pragma description Assassin's Creed: Unity's Compressed .data file | ||
#pragma MIME archives/acu_data_compressed | ||
|
||
// author = haru233, many thanks to AxCut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the #pragma author haru233
pragma here. Then your name will even show up in ImHex
patterns/acu_data_compressed.hexpat
Outdated
@@ -0,0 +1,49 @@ | |||
#pragma description Assassin's Creed: Unity's Compressed .data file | |||
#pragma MIME archives/acu_data_compressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really a valid MIME type? If not, it might be better to use #pragma magic
and specify a sequence of bytes to match against. Or just leave it out entirely
README.md
Outdated
| ZIP | `application/zip` | [`patterns/zip.hexpat`](patterns/zip.hexpat) | End of Central Directory Header, Central Directory File Headers | | ||
| ZLIB | `application/zlib` | [`patterns/zlib.hexpat`](patterns/zlib.hexpat) | ZLIB compressed data format | | ||
| ZSTD | `application/zstd` | [`patterns/zstd.hexpat`](patterns/zstd.hexpat) | Zstandard compressed data format | | ||
| MOD | `3d-model/mod` | [`patterns/DMC3HD-Mod.hexpat`](patterns/dmc3_hd_mod.hexpat) | 3D Model files used in Devil May Cry 3 HD Collection | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be alphabetically ordered. Also the name you specified here is not really standard, I'd name them for what they are. For example "Devil May Cry 3 3D Model" or Assassin's Creed Unity Forge Archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if you move them to a subfolder, simply name it "Assassin's Creed: Unity"
No description provided.