run test for vxWorks in 'pure' static linking mode by default; #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-salim
reviewed
Aug 27, 2019
src/tools/compiletest/src/runtest.rs
Outdated
| @@ -1999,7 +2022,8 @@ impl<'test> TestCx<'test> { | |||
| } | |||
|
|
|||
| if !is_rustdoc { | |||
| if self.config.target == "wasm32-unknown-unknown" { | |||
| if self.config.target == "wasm32-unknown-unknown" | |||
| || self.is_vxworks_pure_static() { | |||
There was a problem hiding this comment.
Weirdly the rust sources don't seem to use a consistent formatting convention! However let's try to be self consistent. Based on other files I think the indentation you used at line 2072 should also be used here, i.e.
if xxx
|| yyy
if environment variables 'RUST_TEST_DYLINK' is set to 1, then run test in 'pure' dynamic linking mode
BaoshanPang
force-pushed
the
bpang-runtest
branch
from
9ef5afd to
cae6d66
Compare
n-salim
previously approved these changes
Aug 29, 2019
|
@n-salim |
n-salim
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if environment variables 'RUST_TEST_DYLINK' is set to 1, then run test in 'pure' dynamic linking mode
revise the code in a more vxworks specific way, I am hoping this can make the upstreaming easier.
r? @n-salim