Skip to content

Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() #429

merged 2 commits into from
Jul 20, 2022

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #428

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jul 15, 2022
@mukeshpanchal27 mukeshpanchal27 requested review from felixarntz, jjgrainger and mehulkaklotar and removed request for felixarntz and jjgrainger July 15, 2022 05:56
mehulkaklotar
mehulkaklotar reviewed Jul 15, 2022
View reviewed changes
@felixarntz felixarntz added this to the 1.4.0 milestone Jul 15, 2022
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jul 15, 2022
mehulkaklotar
mehulkaklotar approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

felixarntz
felixarntz approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Great, thanks!

@felixarntz felixarntz merged commit bfa6d75 into trunk Jul 20, 2022
@felixarntz felixarntz deleted the fix/428-add-constant branch July 20, 2022 11:11
@felixarntz felixarntz changed the title Add constant for plugin_dir_path Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mehulkaklotar mehulkaklotar mehulkaklotar approved these changes

@jjgrainger jjgrainger Awaiting requested review from jjgrainger

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Use constant for plugin_dir_path
3 participants
@mukeshpanchal27 @felixarntz @mehulkaklotar