-
Notifications
You must be signed in to change notification settings - Fork 322
Playground CLI: Wire up execution modes for Blueprints v2 #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Playground CLI: Wire up execution modes for Blueprints v2 #2519
Conversation
I adapted the existing run-cli tests to also test using I'd also like to add more tests specific to Blueprints v2 as part of this PR. |
* Playground should not modify the mounted directory. | ||
*/ | ||
expect(await getDirectoryChecksum(tmpDir)).toBe(checksum); | ||
expect(response.text).toContain('<title>My Blog Name</title>'); | ||
}); | ||
|
||
test('should be able to follow external symlinks in primary and secondary PHP instances', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was incorrectly included within the auto-mount tests, so this is just moving it where it belongs.
Observation: Maybe we should explore HTTPS caching during unit test. |
Not all the pre-existing run-cli tests have to pass for this PR, but the remaining test failures are:
For this PR to be merged, I believe the following need to be done:
|
I did the following:
It looks like the failing |
Motivation for the change, related issues
Without being able to use
apply-to-existing-site
mode with Blueprints v2, it is not practical to launch an existing site using Playground CLI and Blueprints v2. This is a PR to fix that.Related to #2508
Implementation details
This PR:
mode
CLI option for use with Blueprints v2In the categories of bonus, controversial, and up for discussion, this PR also:
npx nx unbuilt-jspi playground-cli
(since the current directory for that command is typically the project root).If desired we can split this change off into a separate PR, but I made the change here in order to make testing easier.
Testing Instructions (or ideally a Blueprint)