Skip to content

Null safety #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Null safety #60

merged 10 commits into from
Apr 28, 2023

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Apr 16, 2023

Migrate to null safety.

@aviary3-wk
Copy link

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(1) Security relevant changes were detected
  • Watched file lib/src/transformed_source_file.dart modified
  • Action Items

    • Obtain a security review; reviewer should pay special attention to insights listed above
    • Verify aviary.yaml coverage of security relevant code

    Questions or Comments? Reach out on Slack: #support-infosec.

    @robbecker-wf robbecker-wf marked this pull request as ready for review April 18, 2023 21:45
    @robbecker-wf
    Copy link
    Member Author

    QA+1 CI passes
    consumer testing passes @Workiva/release-management-p

    @corwinsheahan-wf
    Copy link
    Contributor

    security +1

    • Changes just accomodate null safety by allowing null types, which were already allowed. No functional changes in flagged file

    Copy link

    @rmconsole-wf rmconsole-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +1 from RM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants