Fix sockopt.TcpKeepAliveInterval #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Keep-Alive configs may be overridden with golang default settings when `tcpKeepAliveInterval` is set without `tcpKeepAliveIdle`.
cubarco
added a commit
to cubarco/v2ray-core
that referenced
this pull request
Nov 11, 2022
The Keep-Alive configs may be overridden with golang default settings when `tcpKeepAliveInterval` is set without `tcpKeepAliveIdle`. Adopt: XTLS/Xray-core#1328
|
感谢大佬！ |
xiaokangwang
pushed a commit
to cubarco/v2ray-core
that referenced
this pull request
Feb 19, 2023
The Keep-Alive configs may be overridden with golang default settings when `tcpKeepAliveInterval` is set without `tcpKeepAliveIdle`. Adopt: XTLS/Xray-core#1328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果配置中只设置了
"tcpKeepAliveInterval": -1，而没有设置"tcpKeepAliveIdle": -1，xray不会设置goStdKeepAlive，导致后面dial或者accept的时候，keepalive配置被golang官方默认的覆盖。