Update Microsoft.Data.SqlClient to version 5.2.1 #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitvipin
approved these changes
Nov 6, 2024
adamsitnik
approved these changes
Dec 2, 2024
|
@abmaonline please accept the license #2270 (comment) |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2270 +/- ##
==========================================
- Coverage 64.25% 64.09% -0.17%
==========================================
Files 248 248
Lines 8399 8302 -97
Branches 590 575 -15
==========================================
- Hits 5397 5321 -76
+ Misses 2853 2838 -15
+ Partials 149 143 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Package update fixes a regression in the Microsoft SqlClient causing issues with linux clients (it also broke ef core connections since it started to use the broken client): https://github.com/dotnet/SqlClient/releases/tag/v5.2.1
Which issue(s) this PR fixes:
No issue yet, should I create an issue first?
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list: