Handle helper installation errors #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKiazyk
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ignoring errors (either cancellation or failure) from helper installation, this change throws them so callers can react appropriately. Previously, whatever was being done that required the helper would proceed as if installation succeeded, which would always fail. Now, cancellation or failures will complete the subscriptions without attempting the next steps, and without showing more errors to the user. The initial error, for example cancellation in the below screenshot, will still be shown.
The second commit makes a small change to how auth error messages are created to avoid describing the optional wrapper type with
Optional(...).Closes #69