Skip to content

Switch from Pybind11 to Nanobind #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 14, 2025
Merged

Switch from Pybind11 to Nanobind #2015

merged 6 commits into from
Jan 14, 2025

Conversation

erwei-xilinx
Copy link
Collaborator

A mechanical move following the LLVM commit: llvm/llvm-project#120473

Motivation: https://nanobind.readthedocs.io/en/latest/why.html

fifield
fifield reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove pybind11 from requirements.txt

@fifield fifield requested a review from jgmelber January 13, 2025 16:05
fifield
fifield reviewed Jan 13, 2025
View reviewed changes
@erwei-xilinx
Copy link
Collaborator Author

Please also remove pybind11 from requirements.txt

It seems that the mlir_configure_python_dev_packages in MLIR still requires both pybind11 and nanobind to be present in the system for now.

@erwei-xilinx erwei-xilinx added this pull request to the merge queue Jan 14, 2025
Merged via the queue into Xilinx:main with commit 929a6a1 Jan 14, 2025
53 checks passed
@erwei-xilinx erwei-xilinx deleted the switch_from_pybind11_to_nanobind branch January 14, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield fifield left review comments

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwei-xilinx @fifield