Angular-ui-router version 0.2.18 with ui-sref-active #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameters to the $IncludedByStateFilter:
- params
- options
This allows to use more parameters on this filter and not only the fullOrPartialStatename parameter.
Thanks to this improvement, the following now works (takes in account the id param):
<div ng-show="'**.foo.**' | includedByState:{id: 'new'}">It works</div>
Closes angular-ui#1735
Github -> GitHub
- Adds support for optional spaces in url param typing, i.e. `url:
'foo/{bar: int}'`
feat(urlMatcher): add support for optional spaces
…ement feat($IncludedByStateFilter): add parameters to $IncludedByStateFilter
…ontain periods This change modifies the searchPlaceholder regex to include the period character as valid for url query param names. This change also modifies the regex found in the addParameter function which validates the param name just prior to adding to the list of parameters. A new set of unit tests were added to urlMatcherFactorySpec to ensure this modification works correctly. This change resolves issue angular-ui#2395
Re-added the saved hash before broadcasting $stateChangeStart. This way, libraries using this event to do their magic will have the hash accessible through toParams. (e.g. https://github.com/Narzerus/angular-permission)
…rmissions-plugins fix(transitionTo): re-added the saved hash before broadcasting event
fix(UrlMatcher): Fix broken pre-replace logic Closes angular-ui#2222
Closes angular-ui#2339 Closes angular-ui#2172 Closes angular-ui#2250 Closes angular-ui#1119
…OnSearch=false Closes angular-ui#2356
… has started Closes angular-ui#2238 Closes angular-ui#2229 Closes angular-ui#2185 Closes angular-ui#2236 Closes angular-ui#2098 Closes angular-ui#600
make tests suite compatible with 1.4.x
fix(common.js): "Cannot read property 'params' of undefined" errors Closes angular-ui#2327
fix(uiSrefActive): update the active classes when compiled
…fix(ui-view) use static renderer if animations not enabled . Closes angular-ui#2485
fix(uiState): Corrected variable (angular-ui#2488, angular-ui#2508)
- Adds support for optional spaces in url param typing, i.e. `url:
'foo/{bar: int}'`
…ontain periods This change modifies the searchPlaceholder regex to include the period character as valid for url query param names. This change also modifies the regex found in the addParameter function which validates the param name just prior to adding to the list of parameters. A new set of unit tests were added to urlMatcherFactorySpec to ensure this modification works correctly. This change resolves issue angular-ui#2395
Re-added the saved hash before broadcasting $stateChangeStart. This way, libraries using this event to do their magic will have the hash accessible through toParams. (e.g. https://github.com/Narzerus/angular-permission)
fix(UrlMatcher): Fix broken pre-replace logic Closes angular-ui#2222
Closes angular-ui#2339 Closes angular-ui#2172 Closes angular-ui#2250 Closes angular-ui#1119
…OnSearch=false Closes angular-ui#2356
… has started Closes angular-ui#2238 Closes angular-ui#2229 Closes angular-ui#2185 Closes angular-ui#2236 Closes angular-ui#2098 Closes angular-ui#600
make tests suite compatible with 1.4.x
…fix(ui-view) use static renderer if animations not enabled . Closes angular-ui#2485
The folder bower_components don't have to be included on npm registry
The current implementation of the yuicompressor throws an error when minifying the defaultTypes of the urlMatcherFactory because int is an invalid property id. Changed the property names to string values.
caues → cause
This reverts commit b5c57c8. Closes angular-ui#2501 Closes angular-ui#2496
The parameters are now applied when transitioning to a child state. Closes angular-ui#2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.