Gate POSIX-only signals and resource module to only run on POSIX Pyth… #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on implementations.
The
resourcemodule exposes an interface to the POSIX-compliantget/setrlimit()functions which allow a user to set resource usage of an application. Unfortunately, this functionality isn't exposed on Windows, even on MinGW; the module doesn't exist.This isn't great, but seeing as I need the SMT backend and I'm on a Windows machine, my current solution is to just gate out the POSIX-only functionality for now. Since this is potentially limiting on larger problems, when I have more time, I'll look into alternate solutions.
Similarly,
SIGHUPisn't exposed as a signal in thesignalmodule as well (nor does it make sense on Windows), so I gated this as well. I testedSIGINTand it works fine; AFAICT, it's impossible to sendSIGTERM, but the identifier exists withinsignal, so I left it alone.