RuntimeException: stop failed after recording is completed

[sagrawal31]

Description

I'm using the latest master 1bf79f9 to run the app locally for testing and surprised to see this isn't working.

As soon as the 20s is completed (or even I manually submit the recording), an exception is being thrown:

D/CameraFullscreenRecorderActivity: Recorder. RecordingProgress:19000
D/CameraFullscreenRecorderActivity: Recorder. microphoneHealth:BAD
D/CameraFullscreenRecorderActivity: Recorder. RecordingProgress:20000
D/CameraFullscreenRecorderActivity: Recorder. microphoneHealth:MODERATE
D/ZRecorder$Builder: onInfo. mr:com.ziggeo.androidsdk.recorder.ZRecorder@8d65d01 
    What:800
    Extra:0
I/MediaRecorderJNI: stop
E/MediaRecorder: stop failed: -1007
D/AndroidRuntime: Shutting down VM
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.ziggeo.androidsdk.demo, PID: 11867
    java.lang.RuntimeException: stop failed.
        at android.media.MediaRecorder._stop(Native Method)
        at android.media.MediaRecorder.stop(MediaRecorder.java:1378)
        at com.ziggeo.androidsdk.widgets.cameraview.CameraViewImpl.releaseMediaRecorder(CameraViewImpl.java:264)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2Api23.releaseMediaRecorder(Camera2Api23.java:32)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2.stopRecording(Camera2.java:302)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2.lambda$prepareMediaRecorder$3$Camera2(Camera2.java:831)
        at com.ziggeo.androidsdk.widgets.cameraview.-$$Lambda$Camera2$hdojrmf2WsZ_VyKq2h4wIE2i4VA.onInfo(Unknown Source:2)
        at com.ziggeo.androidsdk.recorder.ZRecorder$Builder.lambda$build$0$ZRecorder$Builder(ZRecorder.java:133)
        at com.ziggeo.androidsdk.recorder.-$$Lambda$ZRecorder$Builder$RWH90Gu1RcipHZx_2oCneulCrkw.onInfo(Unknown Source:2)
        at android.media.MediaRecorder$EventHandler.handleMessage(MediaRecorder.java:1706)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7081)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
W/System.err: java.lang.RuntimeException: stop failed.
        at android.media.MediaRecorder._stop(Native Method)
        at android.media.MediaRecorder.stop(MediaRecorder.java:1378)
        at com.ziggeo.androidsdk.widgets.cameraview.CameraViewImpl.releaseMediaRecorder(CameraViewImpl.java:264)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2Api23.releaseMediaRecorder(Camera2Api23.java:32)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2.stopRecording(Camera2.java:302)
        at com.ziggeo.androidsdk.widgets.cameraview.Camera2.lambda$prepareMediaRecorder$3$Camera2(Camera2.java:831)
W/System.err:     at com.ziggeo.androidsdk.widgets.cameraview.-$$Lambda$Camera2$hdojrmf2WsZ_VyKq2h4wIE2i4VA.onInfo(Unknown Source:2)
        at com.ziggeo.androidsdk.recorder.ZRecorder$Builder.lambda$build$0$ZRecorder$Builder(ZRecorder.java:133)
        at com.ziggeo.androidsdk.recorder.-$$Lambda$ZRecorder$Builder$RWH90Gu1RcipHZx_2oCneulCrkw.onInfo(Unknown Source:2)
        at android.media.MediaRecorder$EventHandler.handleMessage(MediaRecorder.java:1706)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7081)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

I even tried upgrading the dependency from 0.82.0 to com.github.ZiggeoJitpackService:Android-SDK:0.83.0_rc4 but it also has the same issue.

Environment

• OS: macOS Catalina
• Android version: 9
• Device: Samsung J6

[sagrawal31]

Also, I'm not sure why the version 0.82.1 is not available here https://jitpack.io/#ZiggeoJitpackService/Android-SDK?

[sagrawal31]

I can see a popular solution here https://stackoverflow.com/questions/16221866/mediarecorder-failed-when-i-stop-the-recording

[3akat]

Hi @sagrawal31!
Thanks for reporting it, will take a look shortly.

[sagrawal31]

Thank you @3akat for the reply.

Wanted to update, not sure why but the same app works fine in an Emulator running Android 8.

[sagrawal31]

Any update here guys? We are eagerly waiting for a fix/solution/workaround.

[Bane-D]

Hi Shashank,

My colleague is looking into this. As soon as there is an update he will push it up and update you that it is available. :)

[3akat]

Hi @sagrawal31, thank you for the detailed description, but I was not able to reproduce the issue on my devices and emulators. Looks like the issue is specific to a Samsung device, I'm trying to understand what's going on.
The link you've shared is actually a workaround for the symptom (the crash). The actual reason is that the recording seems not starting on your device for some reason.
Doing my best to reproduce the issue and fix it ASAP.

[sagrawal31]

Hi @3akat I'm not really sure what's happening in the Samsung device. This device is the latest and only a year old. So this shouldn't be a problem.

What is the next step are you taking to figure out the problem? Do you need something from my side?
I will be happy to do it.

[sagrawal31]

@3akat I have been doing the research about this and I got this https://stackoverflow.com/questions/52084401/android-mediarecorder-not-working-in-some-devices

To help you out (and ultimately, to help myself 😃), can you let me know a way that I can set mediaRecorder.setAudioEncoder(MediaRecorder.AudioEncoder.AMR_NB); somewhere in the code?

[sagrawal31]

This is just my guesswork, so please feel free to say no if you are confident that this won't work :)

[sagrawal31]

I literally have no knowledge of this media/camera thing but I can see that the audio encoder is set to 3 i.e. MediaRecorder.AudioEncoder.AAC in ZRecorder.java:

So can you release a snapshot version which gives us the ability to customize the audio encoder and then I can change & try in my Samsung device?

[sagrawal31]

See it says here the same that MediaRecorder.AudioEncoder.AAC does not work on Samsung https://developer.samsung.com/forum/thread/samsung-device-does-not-support-sharing-of-mic-/201/300866?boardName=SDK&listLines=30&startId=zzzzz~&startPage=28&curPage=30

[sagrawal31]

Another thread which might jog your mind react-native-audio-toolkit/react-native-audio-toolkit#149

[3akat]

Yup, that could be the cause. My main goal now is to reproduce the issue before fixing it. I wasn't able to find the J6 device, but I will test the app on some other Samsungs with android 8 and 9.
Meanwhile, I'll add ability to configure the audio encoder and you'll be able to try it by yourself :)

[sagrawal31]

Sure, @3akat let me know once you released it. I'll try it out.