Dev #311
Dev #311
Conversation
dont connect to lotus node > 1.5.0
# Conflicts: # .circleci/config.yml # .github/workflows/main.yml # go.mod # go.sum # rosetta/services/account.go # rosetta/services/block.go # rosetta/services/constants.go # rosetta/services/helpers.go # rosetta/services/mocks/fullnode_mock.go # rosetta/tests/rosetta-config-PR-calibration.json # rosetta/tests/rosetta-config-PR-mainnet.json # rosetta/tests/rosetta_cli_test_PR.sh # rosetta/tests/rosetta_cli_test_push.sh
# Conflicts: # main.go
Summary of ChangesHello @lawRathod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several new import statements to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds three new package imports to main.go: errors, strings, and github.com/Masterminds/semver. However, these packages are not used within the file, which will cause a compilation error in Go. I have provided a review comment with a code suggestion to remove these unused imports. Additionally, the go.mod file was not updated to include the new semver dependency, which would also cause build issues.
| "context" | ||
| "errors" | ||
| "fmt" | ||
| rosettaFilecoinLib "github.com/zondax/rosetta-filecoin-lib" | ||
| "net/http" | ||
| "os" | ||
| "os/signal" | ||
| "strconv" | ||
| "strings" | ||
| "syscall" | ||
| "time" | ||
|
|
||
| "github.com/Masterminds/semver" | ||
| rosettaAsserter "github.com/coinbase/rosetta-sdk-go/asserter" | ||
| "github.com/coinbase/rosetta-sdk-go/server" | ||
| "github.com/coinbase/rosetta-sdk-go/types" |
There was a problem hiding this comment.
The packages errors, strings, and github.com/Masterminds/semver are imported but not used. Unused imports will cause a compilation error in Go. Please remove them. Additionally, if github.com/Masterminds/semver were to be used, it would need to be added to your go.mod file.
| "context" | |
| "errors" | |
| "fmt" | |
| rosettaFilecoinLib "github.com/zondax/rosetta-filecoin-lib" | |
| "net/http" | |
| "os" | |
| "os/signal" | |
| "strconv" | |
| "strings" | |
| "syscall" | |
| "time" | |
| "github.com/Masterminds/semver" | |
| rosettaAsserter "github.com/coinbase/rosetta-sdk-go/asserter" | |
| "github.com/coinbase/rosetta-sdk-go/server" | |
| "github.com/coinbase/rosetta-sdk-go/types" | |
| "context" | |
| "fmt" | |
| rosettaFilecoinLib "github.com/zondax/rosetta-filecoin-lib" | |
| "net/http" | |
| "os" | |
| "os/signal" | |
| "strconv" | |
| "syscall" | |
| "time" | |
| rosettaAsserter "github.com/coinbase/rosetta-sdk-go/asserter" | |
| "github.com/coinbase/rosetta-sdk-go/server" | |
| "github.com/coinbase/rosetta-sdk-go/types" |
4 participants
🔗 zboto Link