Skip to content

Feature/667 zarr 3 support #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025
Merged

Feature/667 zarr 3 support #668

merged 7 commits into from
Apr 9, 2025

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented Apr 8, 2025

Description

This PR closes #667

Changes

  • bump version dependency to zarr
  • fix import due to version update

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk schroedk requested review from mdbenito and Copilot April 8, 2025 14:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • requirements-extras.txt: Language not supported

Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Although this is very mysterious. I have just had CI fail on the notebook tests because requirements-notebooks.txt pins zarr to 2.16 and there is no constraint on numcodecs, but the jobs on this PR haven't failed... 🤷🏽

I think we should apply the same logic to requirements-notebooks.txt just in case.

@mdbenito mdbenito merged commit b991432 into develop Apr 9, 2025
37 of 38 checks passed
@mdbenito mdbenito deleted the feature/667-zarr-3-support branch April 9, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarr < 3 and numcodecs
2 participants