-
Notifications
You must be signed in to change notification settings - Fork 22
Switch branch Action #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Switch branch Action #286
Conversation
Remove the backlog link from the description. Instead add some description of what the pull request solves.
|
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/AbapGitView.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/SwitchbranchAction.java
Outdated
Show resolved
Hide resolved
...bapgit/adt/ui/internal/repositories/wizards/AbapGitWizardPageBranchSelectionCredentials.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...i/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardPageBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/repositories/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
@aarnapant-sap Please also test the solution in a ABAP Cloud system, involving transport requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Aarnav,
Overall looks good.
I have added some comments and questions. Please check them.
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/SwitchbranchAction.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
...dt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageRepositoryAndCredentials.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardBranchSelection.java
Outdated
Show resolved
Hide resolved
....ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageBranchSelectionCredentials.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/SwitchbranchAction.java
Outdated
Show resolved
Hide resolved
....adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageSwitchBranchAndPackage.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardSwitchBranch.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardSwitchBranch.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardSwitchBranch.java
Outdated
Show resolved
Hide resolved
org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardSwitchBranch.java
Outdated
Show resolved
Hide resolved
public class TestPdeAbapGitRepositoriesSelectionWizard { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- More test cases can be covered like invalid package or exception while fetching repo type.
- Also a UI test can be added to open the wizard, validate the fields in first page, then navigate to next page and validate if the branches are correctly set as input for combo viewer, and switch the branch in combo viewer. The Finish action can be skipped.
…ted check to action
Switch Branch Functionality in AbapGit