Skip to content

Switch branch Action #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

aarnapant-sap
Copy link
Contributor

@aarnapant-sap aarnapant-sap commented Jan 3, 2025

Switch Branch Functionality in AbapGit

  • User can now switch branch for the linked repository without explicitly unlinking and relinking.
  • SwitchBranchAction is added to context menu in AbapGitRepository view.
  • added pde tests for switchBranchWizard

@shubhamWaghmare-sap
Copy link
Collaborator

Remove the backlog link from the description. Instead add some description of what the pull request solves.

  • backlog link click here support for branch switching for a linked repository

@shubhamWaghmare-sap
Copy link
Collaborator

@aarnapant-sap Please also test the solution in a ABAP Cloud system, involving transport requests.

Copy link
Collaborator

@shubhamWaghmare-sap shubhamWaghmare-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aarnav,
Overall looks good.
I have added some comments and questions. Please check them.

Comment on lines 17 to 18
public class TestPdeAbapGitRepositoriesSelectionWizard {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • More test cases can be covered like invalid package or exception while fetching repo type.
  • Also a UI test can be added to open the wizard, validate the fields in first page, then navigate to next page and validate if the branches are correctly set as input for combo viewer, and switch the branch in combo viewer. The Finish action can be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants