Fixed CUBLAS DLL load issues on Windows #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change fixes DLL load issues when CUBLAS is enabled on Windows.
Symptoms:
Root cause:
Python for Windows does not search for DLLs in directories listed in PATH environment variables. So CUDA libraries are not available while loading llama.dll. Hence the error module or dependencies not found.
Python change log for Windows
Fix:
Add CUDA_PATH to dll search directory via add_dll_directory
Result: