Added request and response logging for debugging reasons #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 12, 2014 12:51
|
Hi Konstantinos, I don't think these messages add much weight even for debugging purposes. You are dumping entire body which may contain binary content (images) too. I will have to close this since this branch has also run out of HEAD. |
ghost
mentioned this pull request
abhinavsingh
pushed a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this proxy, even though I was able to do my job by just transferring packages through this, I could not debug anything. I needed to know the request my code was sending and the response I'd receive back, in order to check if everything was okay. And this kind of logging might be helpful anyway.