[Work] Refactor as FD work #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavsingh
added
the
bot:chronographer:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1049 +/- ##
===========================================
- Coverage 87.15% 87.10% -0.06%
===========================================
Files 157 159 +2
Lines 6608 6628 +20
Branches 669 671 +2
===========================================
+ Hits 5759 5773 +14
- Misses 738 744 +6
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhinavsingh
changed the title
abhinavsingh
added a commit
that referenced
this pull request
Jan 24, 2022
* [Windows] Remove `--threadless` from `TestCase` (#1025) [Windows] Remove `--threadless` from `TestCase` * Handle `SIGINFO`. Try `kill -s INFO <pid>`. (#1024) * Handle `SIGINFO`. Try `kill -s INFO <pid>`. Also remove dirty hack added in flags to incorporate `--basic-auth` flag. Add `__pycache__` to ignore list. Disable http proxy during acceptor benchmark. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * not on windows * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * no cover * # pylint: disable=E1101 * Curl retry on error and check_output 2 minute timeout * check output timeout None * Update `faulthandler_timeout` to 2 minutes * Disable `test_circular_imports`, `isort` integration now works * Fix curl flags * Revert back to older flags * SIGINFO attribute might not even exist Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add a skeleton app to demonstrate how to use `proxy.py` for standalone projects (#1029) * Add a skeleton app structure * Update `README.md` for skeleton app * Add `skeleton-app` to pre commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update readme Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Move `Tls` module within core (#1030) * [ReverseProxy] Move within core lib with ability to write its plugin (#1033) * Move reverse proxy core within core lib * Fix main test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix doc and lint * Fix lint * Top level category for reverse plugin Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Multiport] Prepare for listening on multiple ports (#1031) * Convert `--port` to list of integers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Prepare for multiport listener * Multi listeners, but will fail in theory as no port override is currently performed * Separate `listener` module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update flags in readme * Fix imports in listener test * Fix flag parsing for `port` and `ports` * Fix tests Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Multiport] `Acceptor` can now accept work from multiple descriptors (#1036) * Update acceptor to accept work from multiple ports * import order * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix acceptor tests * Tweak * fix tests Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [ReverseProxy] Add integration tests (#1037) * Add reverse proxy integration test * Fix reverse proxy url for https integration * Enable reverse proxy for docker build and test * [ReverseProxyPlugin] Remove redundant `ca_file` flag when wrapping upstream (#1046) * Fix #1045 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * no conn log * Do not edit host header by default Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [SOCKS4] Packet parser & builder (#1047) * Initial commit * Parse socks4 packet * Lint check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix lint issues * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add handler test skeleton * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [CacheByContentTypePlugin] Prepare for content type parsing (#1038) * Move default cache directory within `proxy.py` instance data directory * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add `CacheByContentTypePlugin` skeleton and remove unnecessary mixin * Fix startup issues after removal of mixin * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . * Fix broken mock * doc fix * doc Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Work] Refactor for generic work type (#1048) * Add `TcpOrTlsSocket` type * isort * Update to use Fd executor * Define `HostPort` type * Fix fileno * spellfix * [Work] Refactor as FD work (#1049) * Abstract out FD based work implementation * No need of local/remote abstractions * fix type * Add `BaseLocalExecutor` * Fix lint and tests * [BaseRemoteExecutor] Base executor for processing work remotely (#1050) * Abstract out FD based work implementation * No need of local/remote abstractions * fix type * Add `BaseLocalExecutor` * Fix lint and tests * Add a `BaseRemoteExecutor` * [Work] `kwargs` independent `work_klass` creation and work core (#1051) * `kwargs` independent work klass and core * Fix tests * Add a `create` method to base class * Lint fixes * Pre `v2.4.0rc8` cleanups (#1053) * Pre-release cleanups * Add listener pool test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add multi listener test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specific implementation of work framework has been carved out into a
fdmodule which contains code dealing with file descriptors as work objects.