Skip to content

Minor change that allows for regex replacements when using the revers… #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rpgmaster280
Copy link

Quick solution for regex group replacements for the reverse proxy plugin. See issue #1132

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1172 (2cf1c84) into develop (c93b028) will decrease coverage by 6.81%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1172      +/-   ##
===========================================
- Coverage    87.31%   80.49%   -6.82%     
===========================================
  Files          166      166              
  Lines         6971     6974       +3     
  Branches       708      651      -57     
===========================================
- Hits          6087     5614     -473     
- Misses         757     1228     +471     
- Partials       127      132       +5     
Flag Coverage Δ
pytest 80.49% <0.00%> (-6.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proxy/http/server/reverse.py 0.00% <0.00%> (-92.86%) ⬇️
proxy/core/work/threadless.py 18.71% <0.00%> (-62.57%) ⬇️
proxy/core/work/pool.py 35.00% <0.00%> (-56.67%) ⬇️
proxy/core/work/fd/local.py 46.66% <0.00%> (-53.34%) ⬇️
proxy/core/base/tcp_upstream.py 47.05% <0.00%> (-52.95%) ⬇️
proxy/plugin/modify_chunk_response.py 50.00% <0.00%> (-50.00%) ⬇️
proxy/core/work/fd/remote.py 50.00% <0.00%> (-46.16%) ⬇️
proxy/core/work/delegate.py 44.44% <0.00%> (-44.45%) ⬇️
proxy/core/work/fd/fd.py 47.82% <0.00%> (-43.48%) ⬇️
... and 22 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@abhinavsingh
Copy link
Owner

@rpgmaster280 Just wanted to update, I'll likely to get this PR over coming weekend. Thank you and best.

@abhinavsingh
Copy link
Owner

@rpgmaster280 Please leave your comments on #1180 . I decided to throw the responsibility to what to do with incoming matched route to plugin developers :). Let me know what you think.

Closing this as now regex code written goes into individual plugins. You'll need to write one for dynamic route support. Old style static route support will work as-is.

Thank you for pushing me here. I hope we'll have something stable out soon.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants