Use ipaddress type and avoid explicit Connection: close header to upstream #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

abhinavsingh merged 3 commits into develop from connection

Sep 22, 2019

Owner

abhinavsingh commented Sep 21, 2019 •

edited

Loading

Fixes #71 and #75

Previously, an IPv4 address like --hostname 0.0.0.0 must be accompanied with --ipv4 flag, since proxy.py now defaults to IPv6 addressing. This is now fixed.
Previously, proxy.py would explicitly add a Connection: close header when sending request to upstream. This is no longer true and client header value is utilized as is.

abhinavsingh added 2 commits

September 21, 2019 16:40


          Fixes #71 and address some of #75

ed4ecba


          Fix tests as IPV6 is default now

bce31e4

abhinavsingh changed the title ~~Use ipaddress type~~ Use ipaddress type and avoid explicit Connection: close header to upstream

abhinavsingh mentioned this pull request

Auto-detect IPv4 / IPv6 listen based upon --hostname arg #71

Closed


          Add comments and raise from e

276448c

abhinavsingh merged commit 5bdfd20 into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet