add note about large reaction summaries getting clipped #2806
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vladvelici
force-pushed
the
chat/clipped-summaries
branch
from
13b9890 to
4590f1a
Compare
|
|
||
| When a summary is clipped: | ||
| - The `total` property shows the total number of reactions as expected, but the `clientIds` property will contain only a partial list of client IDs. | ||
| - There will be a property `clipped` set to `true`. |
There was a problem hiding this comment.
Nitpick - would probably worth this the "clipped" property will be set to true, as otherwise it makes the property sound optional
|
|
||
| If multiple reactions are sent in a short period of time, multiple reactions may be rolled up and only a single summary event will be published that contains the aggregated results of all reactions. This reduces the number of outbound messages and thus your costs in busy rooms. | ||
|
|
||
| #### Large summaries <a id="large-summaries"/> |
There was a problem hiding this comment.
Does this need a language selector conditional until we have it in Kotlin/Swift?
There was a problem hiding this comment.
Should we hide it or let people be aware even if field not yet available?
There was a problem hiding this comment.
Wrapped in <If> in the end
vladvelici
force-pushed
the
chat/clipped-summaries
branch
from
4590f1a to
efbb17d
Compare
vladvelici
force-pushed
the
chat/clipped-summaries
branch
from
efbb17d to
52aa079
Compare
Description
https://ably.atlassian.net/browse/CHA-1098
https://ably.atlassian.net/browse/CHA-1099
Checklist