-
-
Notifications
You must be signed in to change notification settings - Fork 20
Add setup files, Author and Changelog #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pombredanne wrt to aboutcode-org/scancode.io#35, please provide feedback over this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 This is looking good, see my few comments.
setup.cfg
Outdated
attrs | ||
packageurl-python | ||
requests | ||
six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make these all 4-space indents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to my eye, however there is a Travis build failure here: https://travis-ci.org/github/nexB/fetchcode/builds/740005065
Hi @MaJuRG how can we resolve it? In earlier config all tests were passing, I can't understand why they are failing now, need some help on that |
To reiterate our conversation on https://gitter.im/aboutcode-org/discuss: At first glance it looks like some import errors for some of the internal pip modules. |
This is caused because pytest is collecting the files at https://github.com/TG1999/fetchcode/tree/publish/src/fetchcode/vcs/pip for running doctests. That probably casues some collisions with some internal pip modules . One way to fix this would be to be explicit about test discovery. Essentially replacing https://github.com/TG1999/fetchcode/blob/b95dd97f75c152cc2e9f88d61f16051bc765f3a7/.travis.yml#L17 to either |
Signed-off-by: Tushar Goel <[email protected]>
Thanks @sbs2001 |
Ping @MaJuRG @pombredanne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Sorry for the belated review!
Signed-off-by: TG1999 [email protected]