Fix template path handling and make output parameter required #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 28d43b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the template path handling by replacing a hardcoded directory with the process working directory and makes the output parameter for the generate templates command required.
- Update changelog files to document the patch changes
- Mark the output parameter as required in the command configuration
- Replace a hardcoded root path with process.cwd() in the template generation process
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .changeset/chubby-bats-brake.md | Documenting the change to use process.cwd() for rootDir |
| .changeset/silver-shirts-visit.md | Documenting making the output path required in generateTemplatesCommand |
| index.ts | Adding a required flag for the output parameter in the command configuration |
| src/commands/generate-templates/templates-gen-process.ts | Changing rootDir from a hardcoded path to process.cwd() |
… templates generation process Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
fix-gen-template
branch
from
37e5a4c to
28d43b4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #853
Closes #935