Skip to content

Fix unreserve logic #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

smorimoto
Copy link
Collaborator

Summary

  • fix unreserve so it updates the internal reserved list
  • remove the previously added unit test

Testing

  • corepack enable && yarn test (fails: Couldn't find the node_modules state file)

Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 2a2f241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smorimoto smorimoto force-pushed the codex/add-unit-test-for-nameresolver-unreserve branch from 2a2f241 to e1dfe39 Compare May 16, 2025 23:54
@smorimoto smorimoto requested a review from Copilot May 16, 2025 23:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the unreserve logic so that the internal list of reserved names is properly updated.

  • The unreserve method now assigns the filtered result back to this.reservedNames.
  • The previously added unit test was removed.
Comments suppressed due to low confidence (1)

src/util/name-resolver.ts:33

  • Assigning the filtered result back to this.reservedNames addresses the bug where the list was not updated; please verify that this change resolves the issue consistently.
this.reservedNames = this.reservedNames.filter(

@smorimoto smorimoto marked this pull request as ready for review May 16, 2025 23:56
@smorimoto smorimoto merged commit f8ff3b0 into main May 16, 2025
5 checks passed
@smorimoto smorimoto deleted the codex/add-unit-test-for-nameresolver-unreserve branch May 16, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant