-
Notifications
You must be signed in to change notification settings - Fork 182
Json Instruments V1 - WIP #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
247 commits
Select commit
Hold shift + click to select a range
56fb468
Initial commit for project-level permissions
jacobpenny 5167a0e
Merge remote-tracking branch 'aces/17.1-dev' into project-level-permi…
jacobpenny 916f701
Use bootstrap in surveys
jacobpenny 20e34a2
Update test user statement, update fixture
jacobpenny 038ebd9
Add bilingual JSON instrument support and associated tools
jacobpenny cb3e8f5
Fix JSONInstrumentToLINSTConverter test
jacobpenny 6713d5f
PHPCS fixes
jacobpenny 6dbaedd
PHPCS fixes
jacobpenny 5934e47
PHPCS fixes
jacobpenny 42d154c
Survey style tweak
jacobpenny d1f554d
Add stage-0 babel preset
jacobpenny d395775
Add autoloading for project modules
jacobpenny 346c39c
Add rewrite rule for testotheque SPA
jacobpenny a8c314d
Include project webpack config in main webpack config
jacobpenny 68e78e2
Allow NDB_Page objects to return JSON
jacobpenny d6634d7
Commit compiled js
jacobpenny 7b03845
Survey updates
jacobpenny e6c5ece
Fixed user project multi-select display
bbd3e6c
Create project/modules directory in travis preinstall
jacobpenny b0ee5c8
switched counter out for array_push
8c5144d
Merge pull request #1 from ZainVirani/user_acct_fix
jacobpenny 3f4a3fb
Add migration to base sql files
jacobpenny 6a291d9
Merge branch 'cap-dev' of github.com:jacobpenny/Loris into cap-dev
jacobpenny 1d764f5
Place user_project_rel definition after user definition
jacobpenny 864342b
Add InstrumentLogicParser stub and test harness
jacobpenny 59df095
Tweak js test commands
jacobpenny 569632d
Add webpack.config.test.js
jacobpenny dd74eb7
logic parser implemented
60e36ba
Changed output from raw numerical output to formatted JS code (to be …
dcae44b
logic update
b19f421
Parser tests
af09b01
Boolean ops testing
04befc0
bool ops finished and tested
17f68ce
more bool ops
3c3a21f
more functionality added
914970c
date ops
7184557
2-stage parsing technique
7b78fb2
date + time ops
e859c3b
Merge pull request #1 from ArminTaheri/CAP
ZainVirani 47def4c
2 stage parser
9e137c7
typo
6046d97
rewrote parser
fa38c51
tests
d464a70
reorganize
695e945
bug fixes
3c3e72b
logic fixes
4fc948a
testing
f963ab2
added unit tests
1946790
more unit tests
4943d2e
Create README.md
ZainVirani a98fbfc
Create README.md
ZainVirani e417bf1
deleted old tests
af8070e
Create README.md
ZainVirani 67cc6b9
update readme
f99d4f3
update readme
339c62e
cleanup
6c87d39
update README.md
ZainVirani 3e64400
reorganize
6eca372
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
46ce77d
Merge pull request #2 from ZainVirani/CAP
jacobpenny 5086614
infinite variable nesting implemented + unit tests
34cf089
Update Evaluator.js
ZainVirani afe8f2a
Merge pull request #3 from ZainVirani/CAP
jacobpenny ec10d01
created generate_instrument_schemas.php
46e0226
added schema generator functionality
c7e76d3
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
78709d0
wrapper script
f00629d
Add instrument preview and survey-react
jacobpenny 2b6c6ee
created generate_instrument_schemas.php
4b785da
added schema generator functionality
857677e
wrapper script
3e00684
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
2259744
wrapper writes to file
c77fb10
cleaned code
dda0b43
updated script
f713af0
Merge pull request #5 from ZainVirani/CAP
jacobpenny 821a3fe
Update compiled JS
jacobpenny 5303be5
Stacked radio buttons, improved error messaging
jacobpenny d69b7e2
Merge branch 'cap-dev' of github.com:jacobpenny/Loris into cap-dev
jacobpenny a17a206
fs resolution error in logicParser workaround
jacobpenny 061371c
updated nested variables
e839fa1
parser tests
144e851
Merge pull request #6 from ZainVirani/CAP
jacobpenny 5fc9c60
calc functionality
b3019a0
fix
b47108e
fix2
a6d7fd4
Merge pull request #7 from ZainVirani/CAP
jacobpenny 4e0c089
Lift formula evaluation out of InstrumentForm
jacobpenny a5563cc
Parser and inst schema changes
8c8644e
Update README.md
ZainVirani 7a99bb6
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
b7b9231
Update README.md
ZainVirani f4dfe8b
Update README.md
ZainVirani 7bb5c9e
Update README.md
ZainVirani 2a612f0
Update README.md
ZainVirani 71b6ecf
parser stuff + some branching logic on reqd resp
3d78913
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
e33ece3
php parser
51963c8
Added RequiredResponse functionality with branching logic
f17c80b
php jison port
8513eaf
Parser and inst schema changes
1596c15
Update README.md
ZainVirani 392af93
Update README.md
ZainVirani 9f34634
Update README.md
ZainVirani c06f7c8
Update README.md
ZainVirani 7334ea2
Update README.md
ZainVirani 1496d82
parser stuff + some branching logic on reqd resp
4120807
php parser
d0c6441
Added RequiredResponse functionality with branching logic
4ca63cf
php jison port
36aaae2
Instrument logic tweaks
jacobpenny c6b35b4
Properly center radio group labels
jacobpenny f6a49b6
Recompile instrument-preview
jacobpenny 7df81c8
added render_date
f6a88b5
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
ea7be58
date render fix
9303b87
date picker rendering
e910cfe
Merge branch 'cap-dev' into CAP
ZainVirani 82e09f7
cleanup
5101481
Merge branch 'CAP' of https://github.com/ZainVirani/Loris into CAP
0dd007d
Merge pull request #8 from ZainVirani/CAP
jacobpenny 3feaec0
typo
206574c
Merge pull request #9 from ZainVirani/CAP
jacobpenny 9eb7903
Override input label bolding
jacobpenny 20b5707
Add DOB date picker in instrument preview
jacobpenny 22e7d83
Cast zeros to Number too
jacobpenny 653df96
Add NDB_BVL_Instrument_JSON
jacobpenny 9424c49
Inline calc formulas
jacobpenny ced90d1
Allow array for options in RadioGroupElement
jacobpenny 1ebdc72
Catch null variables errors from Evaluator
jacobpenny 6b0de6f
Distinguish between null and undefined in Evaluator
jacobpenny 3a48021
Add basic template for React instruments
jacobpenny 5393b0d
Php parser (#10)
ZainVirani 166476f
Add instrument view
jacobpenny 9094c2d
Revert setup function signature change
jacobpenny 820f239
Merge branch 'cap-dev' of github.com:jacobpenny/Loris into cap-dev
jacobpenny 79462ba
Recompile instrument-view
jacobpenny c225d3d
Catch type errors in instrument form
jacobpenny 0fd928d
Disable calculated fields
jacobpenny 6e70bee
php parser moved; evaluation handling (#11)
ZainVirani 39623aa
readme updates, handle evaluator errors (#13)
ZainVirani dee5a16
Circular references (#14)
ZainVirani 8250c9b
Cap empty descr (#16)
ZainVirani 286e1c4
Cap hidden field (#15)
ZainVirani 6aecd99
Cap schema gen (#17)
ZainVirani 69c77d4
Add/fix tests for Evaluator, throw custom errors
jacobpenny 53163d1
Refactor for readability, fix small bugs
jacobpenny 4681aa9
Allow arrays for options in RadioGroupElement and SelectElement
jacobpenny ff75678
More refactoring
jacobpenny 7195b52
Compile JS
jacobpenny b7f6e2f
Fix bad merge
jacobpenny ca4d81c
Recompile JS
jacobpenny 78bf03e
Merge remote-tracking branch 'aces/17.1-dev' into cap-dev
jacobpenny 0d095dc
Make project_rel primary keys NOT NULL
jacobpenny 1217cde
Move PHPParser and put into namespace, update tests
jacobpenny 8670c7c
Update _getContext
jacobpenny 0e1d5f2
Add instrument-view to webpack config
jacobpenny 1a94ff3
Cap get context (#19)
ZainVirani 412bf02
Front end validation, refactoring
jacobpenny 8dc875f
Recompile JS
jacobpenny f12cd69
fix rounding
ad3bb74
fixed is_nan (PHP)
02f0a61
fix rounding (#21)
ZainVirani 1821f00
Cap jquery fix (#22)
ZainVirani 829211f
Fix typos
jacobpenny 7afbe48
Merge remote-tracking branch 'jacobpenny/cap-dev' into CAP
754da9c
Implement NDB_BVL_Instrument_JSON::toJSON and use in display
jacobpenny 39db7fe
Update react-survey to use InstrumentFormContainer
jacobpenny bf3afac
Recompile JS
jacobpenny 8bbff45
Merge remote-tracking branch 'jacobpenny/cap-dev' into CAP
9b832a2
Fix RequireResponse issue
jacobpenny f462510
Cap schema fix (#24)
ZainVirani 75e3b25
Save data in survey-react
jacobpenny e7f3d25
Decode survey values as array, not object
jacobpenny 1937c63
Recompile JS
jacobpenny 9b0e461
Merge branch 'cap-dev' of github.com:jacobpenny/Loris into cap-dev
jacobpenny b57fd09
Cap datediff fix (#23)
ZainVirani cef9ae8
Remove unused file
jacobpenny 1ddf04b
Merge branch 'cap-dev' of github.com:jacobpenny/Loris into cap-dev
jacobpenny 1b87b3d
Merge remote-tracking branch 'jacobpenny/cap-dev' into CAP
ca65451
Pass options to InstrumentFormContainer
jacobpenny 2024c9b
Create DirectEntryReact component
jacobpenny 9760a32
Implement backend validation and calculations
jacobpenny 3a2b373
Fix scoping
jacobpenny 3632c33
Recompile JS
jacobpenny ea187f3
Merge remote-tracking branch 'jacobpenny/cap-dev' into CAP
4471ed1
Cap css (#25)
ZainVirani cad3332
fixed date schema and enum
ac03cfc
Change varchars to text for most instrument fields
jacobpenny 02c4ace
Change date(10) to date
jacobpenny 18ce32e
Fix enum values in schema generator
jacobpenny 3c2373f
Update status when survey submitted
jacobpenny 421ee0f
merge conflict
ea4b339
Match parent function signature in NDB_BVL_Instrument_JSON#setup
jacobpenny bb7b5f4
Fix filterElements and invocation of it
jacobpenny c74c7aa
Add documentation for InstrumentForm and InstrumentFormContainer
jacobpenny 8f63f74
Recompile JS
jacobpenny 66eb372
new style
41feb7e
fix banner
99f6a3a
Update survey styles
jacobpenny 41c7f53
Merge branch 'survey-style-changes' into cap-dev
jacobpenny 3eedb09
Remove source map
jacobpenny f14761e
Nicer completion message for surveys
jacobpenny 3e54933
Recompile JS
jacobpenny 980bdcd
Update docs
jacobpenny 878fe19
Merge remote-tracking branch 'aces/17.1-dev' into json-instruments-v1
jacobpenny 9f68ff9
Revert "Initial commit for project-level permissions"
jacobpenny 0c65d57
Revert projectLevelPermission schema changes
jacobpenny 3c27686
Revert testoteque rewrite rule
jacobpenny d3d8f37
Revert various unrelated changes
jacobpenny a7c37bc
Revert webpack changes
jacobpenny 86debcf
Revert more unrelated changes
jacobpenny deb1a81
Remove moment dependency
jacobpenny 1449465
Rename NAIPTestSuite
jacobpenny 796b08c
Recompile JS
jacobpenny 339e9d1
Address PR comments for instrument docs
jacobpenny 62bcbb5
Parser README update
jacobpenny cd5b7a1
Address most PR comments
jacobpenny 026fe0a
font size change (#28)
ZainVirani b998b27
stylistic changes to save button (#27)
ZainVirani 0312a48
fixed center tag
096199a
Merge pull request #32 from naiploris/JI_save_button
ZainVirani e5e5012
Update README.md
ZainVirani 65ae5d7
Never require hidden elements
jacobpenny b919661
insert to test_names (#34)
ZainVirani 1c8e3b7
Fix namespaces, fix indentation
jacobpenny 151f1eb
Set survey mode in react-survey.php
jacobpenny bad54ee
Fix <= bug and add tests
jacobpenny 8947d13
Move ParserTests into own testsuite
jacobpenny 8f4dbb9
Fix context issue
jacobpenny 66b8944
reset radio button (#36)
ZainVirani f8594b4
Cap gen schema fix (#33)
ZainVirani 20b9f4d
Remove format check from NDB_Page
jacobpenny 5732227
Rename calc field to score field
jacobpenny 37679cd
Update instrument schema script
jacobpenny a84d8ee
Add back ->setup call
jacobpenny 6cb0619
Fix lint issues
jacobpenny 3e32895
Add comment placeholders to Parser
jacobpenny 64f4a21
Fix linting issues
jacobpenny f1797b4
Fix linting issues
jacobpenny 13800a5
Fix linting issues
jacobpenny 7f46502
Fix linting issues
jacobpenny 61f96ab
Fix linting issues
jacobpenny 99281c6
Update inlineCalcFormulas to inlineScoreFormulas
jacobpenny 278e887
Eslint
jacobpenny 2d764cc
Recompile JS
jacobpenny 6c9c491
Eslint
jacobpenny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{ | ||
"presets": [ | ||
"react", | ||
"es2015" | ||
"es2015", | ||
"stage-0" | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
.instrument-label { | ||
margin-bottom: 0px; | ||
} | ||
|
||
h1 { | ||
font-size: 24px; | ||
} | ||
|
||
.title { | ||
text-align: center; | ||
margin-bottom: 0px; | ||
} | ||
|
||
.title h1 { | ||
text-align: center; | ||
margin-top: 0px; | ||
margin-bottom: 16px; | ||
} | ||
|
||
label { | ||
font-weight: normal; | ||
text-align: justify; | ||
} | ||
|
||
#banner { | ||
background-color: #08245b; | ||
padding: 10px; | ||
} | ||
|
||
#logo { | ||
max-height: 55px; | ||
padding-right: 5px; | ||
} | ||
|
||
.studyTitle { | ||
color: white; | ||
font-size: 24px; | ||
vertical-align: bottom; | ||
line-height: 1; | ||
} | ||
|
||
.instrumentContainer { | ||
padding: 1% 2% 2% 2%; | ||
} | ||
|
||
.complete { | ||
display: flex; | ||
margin-top: 100px; | ||
justify-content: center; | ||
align-items: center; | ||
font-size: 2em; | ||
} | ||
|
||
#save { | ||
margin: auto; | ||
display: block; | ||
color: white; | ||
background-color: #08245b; | ||
} | ||
|
||
#warning { | ||
color: red; | ||
} | ||
|
||
.asText { | ||
background: none; | ||
border: none; | ||
margin: 0; | ||
padding-bottom: 15px; | ||
text-decoration: underline; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why a special element type is needed for this and not just a normal label and the element group/table types. It seems to just add extra maintenance overhead, but this can be addressed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit awkward I agree.