Skip to content

[issue_tracker] Fix typo & Cleanup close permission #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Apr 16, 2025

Brief summary of changes

This PR modifies the code in modules/issue_tracker/php/edit.class.inc where the drop-down values are set to accommodate for the new permissions that were added in 27. With this code, the "close" option is added to the statuses drop-down in cases where a user has the appropriate permission to close the current issue, and it is not added otherwise.

This PR also fixes a typo in a variable from hasPartialAcess to hasPartialAccess

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Grant a user the "own issue" Issue tracker permission
  2. Ensure that the user can only view and close their own issues
  3. Add the permission to view all issues to the user
  4. They should now be able to view all issues, but still only able to close their own
  5. Add the permission to close own sites' issues to the user
  6. They should now be able to view all issues, but only close issues from their sites
  7. Add the permission to close all issues
  8. The user should now be able to close all issues, including issues at sites that they do not have.

Link(s) to related issue(s)

  • Resolves #NO ISSUE

@CamilleBeau CamilleBeau added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Apr 16, 2025
@CamilleBeau CamilleBeau added this to the 27.0.0 milestone Apr 16, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: issue_tracker PR or issue related to issue tracker module labels Apr 16, 2025
@CamilleBeau CamilleBeau removed the Language: PHP PR or issue that update PHP code label Apr 16, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Apr 16, 2025
@skarya22
Copy link
Contributor

@CamilleBeau update description to have more details

@CamilleBeau CamilleBeau changed the title [issue_tracker] Fix typo & cleanup close permission [issue_tracker] Fix typo & Cleanup close permission May 13, 2025
@adamdaudrich
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: PHP PR or issue that update PHP code Module: issue_tracker PR or issue related to issue tracker module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants