[instruments] Make legacy dictionary use OPTIONAL as a default #9786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ridz1208 I am not quite sure how to test this .. Where is the |
|
@skarya22 ideally you go to the new DQT, if you try to add a filter for an instrument field, with my changes you will get the isEmpty option, without my changes there is only the base operators |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
When declared as single the new DQT does not allow to choose the option "is empty" in the filter. since this trait is used for all legacy instruments, it seems safer to use optional than SINGLE.
Testing instructions (if applicable)
Link(s) to related issue(s)