Skip to content

[Core] Fix redirect URL AGAIN #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 26.0-release
Choose a base branch
from

Conversation

ridz1208
Copy link
Collaborator

Brief summary of changes

Fixes even further what was fixed in #9534. It seems like the fix in the previous PR did not account for arguments coming after the ? in the URL, this new parameter should account for it.

Here is a list of Query params and what they look like in case nother might still be better

    [HTTP_HOST] => localhost:8083
    [REDIRECT_URL] => /candidate_parameters/
    [REDIRECT_QUERY_STRING] => lorispath=candidate_parameters/&candID=446836&identifier=446836
    [QUERY_STRING] => lorispath=candidate_parameters/&candID=446836&identifier=446836
    [REQUEST_URI] => /candidate_parameters/?candID=446836&identifier=446836

Testing instructions (if applicable)

  1. Do the following for several different URLs
  2. log in as a user and navigate to a page
  3. copy the URL form that page and open an incognito window
  4. paste the URL, you should get a 403 error with an option to "try logging in"
  5. click on that option and enter your credentials
  6. make sure you get to the same page as step 2
  7. try same steps for other pages with a diversity of URL formats

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@ridz1208 ridz1208 added Area: UI PR or issue related to the user interface Language: PHP PR or issue that update PHP code 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Difficulty: Simple PR or issue that should be easy to implement, review, or test labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Area: UI PR or issue related to the user interface Difficulty: Simple PR or issue that should be easy to implement, review, or test Language: PHP PR or issue that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant