Support multi-repo checkouts #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test it tonight (UTC+1) and either merge it or let you know. |
|
I had some time so I tested it and it fails for single repo, if you bring back the deleted line ( |
|
I also added some tests so any new changes should be tested against both single repo and multi repo checkouts. |
|
Released (with some fixes of mine) as v6, let me know if it works for you and if you find the tests I added enough for you. |
|
@RikudouSage, awesome. Thanks for future-proofing with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
/github/workspaceas a safe directory doesn't cut it for multi repo checkouts even though the repositories are checked out to its subdirectories. Given that commit action is working in the$INPUT_DIRECTORYalways, I think my proposed solution should work.I have tested with multiple repo checkout: https://github.com/microsoftgraph/msgraph-sdk-raptor/runs/6202062937?check_suite_focus=true
I haven't tested with a single repo checkout.
Related issue on our repository: