Content Negotiation

[alexkreidler]

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

Enables content negotiation in the actix-files FilesService. Uses built-in Actix Accept header parsing, sorts by q parameter, uses mime_guess to determine file extensions from the content-type. Tries all file exts for a given type, then tries the next content type.

TODOs:

• make it optional, add a flag and method to enable in the ServiceFactory
• add limits to the number of content types to try and the number of extensions for each content type to prevent DOS scenarios
• think about/change error handling

Closes #1718

[robjtede]

Thanks for the submission, but I don't think this feature is strong enough to integrate into the official files lib. It seems to me you could build a service on top of actix-files to achieve this functionality.