fix: return types in ffi #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brooooooklyn
commented
May 9, 2023
| impl AsRef<str> for ada_string { | ||
| fn as_ref(&self) -> &str { | ||
| impl ada_string { | ||
| pub fn as_str(self) -> &'static str { |
There was a problem hiding this comment.
This is internal API, and the lifetime of &str is aligned with ada_url, so it's safe to mark it as 'static here
Brooooooklyn
commented
May 9, 2023
| } | ||
| } | ||
|
|
||
| pub fn parse<U: AsRef<str>>(url: U) -> Result<Url, Error> { | ||
| let url_with_0_terminate = std::ffi::CString::new(url.as_ref()).unwrap(); |
There was a problem hiding this comment.
we need a parse(char* string, size_t length) API in ada to avoid memory copy here
There was a problem hiding this comment.
Since the Rust &str is not the null-terminated
Brooooooklyn
commented
May 9, 2023
| @@ -8,7 +8,7 @@ fn main() { | |||
| let mut build = cc::Build::new(); | |||
| build | |||
| .file("./deps/ada.cpp") | |||
| .file("./deps/ada.h") | |||
| .include("./deps/ada.h") | |||
There was a problem hiding this comment.
This line is the root cause of the linking error
anonrig
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.