remove loop_blocking #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Thanks! Will release with #43.
Doesn't impact code in our learning system guides (https://github.com/adafruit/Adafruit_Learning_System_Guides/search?q=loop_blocking&unscoped_q=loop_blocking)
Will merge after MiniMQTT is merged.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 8, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.0 from 5.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#51 from adafruit/accel_config Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.0.0 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#43 from brentru/fix-attribute-error > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#41 from 2bndy5/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MS8607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
satisfies #40
As stated in the referenced issue, this lib's
loop_blocking()will be broken upon next release of minimqtt lib. Thus I removed the method to preempt any incompatibility.