Skip to content

refactor: adds type annotations reported by mypy and updated pylint v… #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2022
Merged

refactor: adds type annotations reported by mypy and updated pylint v… #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a97023
refactor: adds type annotations reported by mypy and updated pylint v…
May 2, 2022
a838853
Merge branch 'main' into add_type_annotations_6
FoamyGuy May 16, 2022
8e68e6c
more specific service type. Adding remaining types
FoamyGuy May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/pycqa/pylint
rev: v2.11.1
rev: v2.12.2
hooks:
- id: pylint
name: pylint (library code)
Expand Down
6 changes: 3 additions & 3 deletions adafruit_ble_ibbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class _SettingsResult(ComplexCharacteristic):
def __init__(self):
super().__init__(properties=Characteristic.NOTIFY)

def bind(self, service):
def bind(self, service: Service) -> _bleio.PacketBuffer:
"""Bind to an IBBQService."""
bound_characteristic = super().bind(service)
bound_characteristic.set_cccd(notify=True)
Expand All @@ -57,7 +57,7 @@ class _RealtimeData(ComplexCharacteristic):
def __init__(self):
super().__init__(properties=Characteristic.NOTIFY)

def bind(self, service):
def bind(self, service: Service) -> _bleio.PacketBuffer:
"""Bind to an IBBQService."""
bound_characteristic = super().bind(service)
bound_characteristic.set_cccd(notify=True)
Expand All @@ -74,7 +74,7 @@ class IBBQService(Service):
_UNITS_CELSIUS_MSG = b"\x02\x00\x00\x00\x00\x00"
_REQUEST_BATTERY_LEVEL_MSG = b"\x08\x24\x00\x00\x00\x00"

def __init__(self, service=None):
def __init__(self, service: Service = None) -> None:
super().__init__(service=service)
# Defer creating buffers until needed, since MTU is not known yet.
self._settings_result_buf = None
Expand Down