You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@prcutler it should be changed. That usage is on the macropad class which isn't what changed so your instinct does make sense. But the macropad actually has a normal display object on it that is being accessed so it will use the new API as well. Here is the code inside of Macropad class where it sets up the display that is being used:
Activity
prcutler commentedon Nov 2, 2023
The file
macropad_grid_layout.py
(https://github.com/adafruit/Adafruit_CircuitPython_MacroPad/blob/main/examples/macropad_grid_layout.py) has this code in it:macropad.display.show(main_group)
on line 17I assume this should not be updated with the
root_group
fix for CP9 as that functionality is from the MacroPad module?FoamyGuy commentedon Nov 2, 2023
@prcutler it should be changed. That usage is on the macropad class which isn't what changed so your instinct does make sense. But the macropad actually has a normal display object on it that is being accessed so it will use the new API as well. Here is the code inside of Macropad class where it sets up the display that is being used:
Adafruit_CircuitPython_MacroPad/adafruit_macropad.py
Lines 292 to 294 in 6490c5d