use filename for OnDiskBitmap #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
OnDiskBitmap-filename
branch
from
0e41476 to
9f4a5f8
Compare
FoamyGuy
approved these changes
Dec 7, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 8, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.13 from 3.5.12: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#131 from adafruit/anecdata-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#145 from dhalbert/make-package > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.9 from 2.4.8: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#27 from FoamyGuy/typing_fix > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.7.2 from 1.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#41 from dhalbert/OnDiskBitmap-filename > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
Pass a filename instead of an open file to
OnDiskBitmap(). Similar fix to adafruit/Adafruit_CircuitPython_PortalBase#53.Also reorder redisplay and fade up to prevent a minor redisplay glitch on the very first picture. Now it displays smoothly.
Tested on a PyPortal. Text
.jsonfiles tested too.