Skip to content

Change NeoPixel pixel order default behavior? #103

Closed
@caternuson

Description

@caternuson

Not sure why GRBW was chosen as default:

self._pixel_order = GRBW if pixel_order is None else pixel_order

This PR:
#102
changed the behavior in a way that seems to be breaking things elsewhere.
adafruit/Adafruit_CircuitPython_NeoTrellis#18
adafruit/Adafruit_CircuitPython_NeoKey#7

There's a simple fix for those - just explicitly specify pixel order, ex:
adafruit/Adafruit_CircuitPython_NeoTrellis#19

But maybe RGB or GRB is a better default?

Also, could potentially change to using strings instead of tuples to match the main NeoPixel library behavior.
https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel/blob/839b55ce88eaf04a60b3d147b13dbaa7d7404c14/neopixel.py#L115-L119

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions