Skip to content

fix(definitions): feed name incorrectly small #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

blaskovicz
Copy link
Contributor

@blaskovicz blaskovicz commented Jul 3, 2020

Grouped feeds can be a max of 258 characters long (128 for the group, a single dot,
and another 128 for the feed name).

Fixes #119

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, feed names (without an appended group) can be >128 characters and we should support that.

However, this PR is failing during clang-format'ing. Could you please fix the formatting errors (https://github.com/adafruit/Adafruit_IO_Arduino/pull/126/checks?check_run_id=835702493#step:6:2) and bump the library version here (https://github.com/adafruit/Adafruit_IO_Arduino/blob/master/library.properties#L2) to 3.6.3?

@blaskovicz
Copy link
Contributor Author

will look at it when i have time, thanks for the feedback 👍

Grouped feeds can be a max of 258 characters long (128 for the group, a single dot,
and another 128 for the feed name).
The max csv length should be 4 characters larger than the max feed name,
so update the definition accordingly.

fixes adafruit#127
@@ -1,5 +1,5 @@
name=Adafruit IO Arduino
version=3.7.0
version=3.7.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be bumped , I'll bump from my end

@brentru
Copy link
Member

brentru commented Sep 23, 2020

This tests properly on hardware.

To test, I created a grouped feed with len 128 and then used example adafruitio_11_group_pub:

Adafruit IO connected.
sending example.ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff-> 0
sending example.count-2 -> 0

On io web, example.ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff correctly obtained value 0

@brentru brentru merged commit cc5331c into adafruit:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of data->feedName() when feed has group
2 participants