Support for Arduino WiFi MKR 1010 and Arduino Nano 33 IOT #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new file is a copy of the original AdafruitIO_MKR1000.cpp but modified for the Arduino MKR1010
This new file is a copy of the original AdafruitIO_MKR1000.h but modified for the Arduino MKR1010
Added support for the Arduino MKR1010
Added support for the Arduino MKR1010
Added support for the Arduino MKR1010
Changes to support MKR 1010 and Nano 33 IOT
updated examples
brentru
requested changes
Dec 8, 2021
There was a problem hiding this comment.
@darumsdad I have two changes for you to make. Please test them, too, as I don't have the Nano 33 IoT
Added include guards Removed not needed code
|
I tested these changes with my Nano 33 IOT and it connects / updates fine. |
|
@darumsdad Could you please run clang-format over the files to make the code more readable? We have a guide about it here: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format Please let me know if you need any help. |
formatting changes
Formatting change
brentru
approved these changes
Dec 10, 2021
|
This looks great, thank you for finishing out a closed PR. Will release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes to complete the work started by mlwinters to add support for Arduino WiFi MKR 1010 and Arduino Nano 33 IOT.
Updated the examples to include instructions for how to enable support these boards