Missing Type Annotations

[tekktrik]

I'm still going through libraries and adding typing, and just wanted to see if there was any benefit to adding those here. I know this isn't necessarily a commonly end-user modified file, so wanted to check.

[makermelissa]

Yeah, I think there is. It will help identify missing things and make it easier to add typing to supported libraries.

[tekktrik]

Sounds good! I'll get on it.

[tekktrik]

I'm having some issues with cyclic imports and the best way to solve it I think would probably be to flatten board.py and chip.py into __init__.py. Wanted to check in about doing so before actually submitting a PR with that change, since it's a pretty decent structural change. Basically the problem is that I can't type the other two files' classes as taking Detector as an argument based on the current structure, and wanted to weigh that change against the benefit of typing

[tekktrik]

Any thoughts on this? I know it would be a somewhat large change, at least in terms of organization of code. If it makes sense not to rearrange, it may warrant just closing this issue.

[makermelissa]

The cyclic import issues may actually mean that the imports might need slight updating. Please don't flatten the files. That will break Blinka until it is updated there too and we recently went through a sizable bump when they were unflattened about a year ago and I'd prefer not to do that.

[makermelissa]

If it's giving you trouble, I can go through and update... Just not today. I just redid all the Blinka Displayio stuff and that was way more complex than this. I think I also bumped into the cyclic import issue with that and just fixed it so it wasn't cyclically importing.

[tekktrik]

Sounds good!