Skip to content

Add Rock Pi 3A compatibility #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

Add Rock Pi 3A compatibility #272

merged 4 commits into from
Jan 30, 2023

Conversation

etrevis
Copy link
Contributor

@etrevis etrevis commented Jan 17, 2023

No description provided.

@etrevis etrevis mentioned this pull request Jan 20, 2023
Merged
makermelissa
makermelissa requested changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. Just for the purpose of trying to keep a large number of boards organized, I'd like to stick with consistent naming. Otherwise, the PR looks good.

adafruit_platformdetect/constants/boards.py Outdated
@@ -165,6 +165,7 @@

RADXA_ZERO = "RADXA_ZERO"
RADXA_CM3 = "RADXA_CM3"
RADXA_3A = "ROCK_PI_3A"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to ROCK_PI_3A to match the other ROCK PI boards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will change it also downstream (blinka)

@etrevis etrevis requested a review from makermelissa January 30, 2023 19:32
makermelissa
makermelissa approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Look great.

@makermelissa makermelissa merged commit 67c8a46 into adafruit:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etrevis @makermelissa