Skip to content

Fix actions install script #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix actions install script #77

merged 1 commit into from
Jun 30, 2020

Conversation

evaherrada
Copy link
Contributor

I've tested this on a fork of this library and locally. Arduino changed the install script, so now it won't work unless you specify the version.

@evaherrada evaherrada requested a review from ladyada June 30, 2020 16:46
@ladyada
Copy link
Member

ladyada commented Jun 30, 2020

?? version of what?

@evaherrada
Copy link
Contributor Author

They now want you to specify the version of arduino-cli to install

@ladyada ladyada merged commit 3db4cc8 into master Jun 30, 2020
@evaherrada evaherrada deleted the dherrada-patch-1 branch June 30, 2020 17:31
@per1234
Copy link
Contributor

per1234 commented Jun 30, 2020

Hi all. The intention definitely wasn't to break support for the previous Arduino CLI installation script behavior, but only to allow the option of specifying a version. I'll put in a PR ASAP to fix the Arduino CLI installation script so the previous behavior of installing the latest release of Arduino CLI when no version is specified works again.

You can then choose whether you want to continue to pin the Arduino CLI version used by your script, or whether you want to revert this PR to make it go back to automatically follow the latest Arduino CLI release version.

@evaherrada
Copy link
Contributor Author

@per1234 Awesome. Thank you.

@ladyada
Copy link
Member

ladyada commented Jun 30, 2020

thanks @per1234 this works for now :) we'll repatch back later

@per1234
Copy link
Contributor

per1234 commented Jul 1, 2020

OK, the installation script is now fixed: arduino/arduino-cli#772

It turned out that the breakage happening around the same time as the addition of version specification support to the script was purely coincidental. The actual cause was that GitHub changed the HTML structure of the releases page, which broke the script's system for scraping the latest tag number from that page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants