ESP NeoPixel fixes #5892
Merged
ESP NeoPixel fixes #5892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the RMT timing to better match the 1/3 and 2/3 of 800khz guideline for timing. It also ensures a delay of 300 microseconds with the line low before reset. Pin reset is now changed to the IDF default which pulls the pin up rather than CircuitPython's old behavior of floating the pin. Fixes micropython#5679
dhalbert
approved these changes
Jan 20, 2022
|
Onboard neopixel is working on um_tinys2 and esp32s3 devkit 👍 |
Adafruit CircuitPython 7.2.0-alpha.1-220-g80611954f on 2022-01-26; ESP32-S3-DevKitC-1-N8R2 with ESP32S3`Seeing hangs (can still control-C; pix[0] = (0, 0, 0)In earlier CP versions, I was seeing these hangs before on Espressif S2 and S3 boards. I think S2 is improved, but it now seems more frequent on S3. Is it possible there is difference in behavior depending on the sequence of inits using various timers? (In similar code, I sometimes get hangs on feeding the watchdog or on reading properties from wifi Monitor, or on setting the NeoPixel) |
|
@anecdata Please open a new issue. Follow up messages on PRs can be hard to track. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the RMT timing to better match the 1/3 and 2/3 of 800khz
guideline for timing. It also ensures a delay of 300 microseconds
with the line low before reset.
Pin reset is now changed to the IDF default which pulls the pin up
rather than CircuitPython's old behavior of floating the pin.
Fixes #5679