Fix ESP32 touch; rework common code a bit #6772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6606.
touch_pad_read()are lower rather than higher when the pin is touched.TOUCH_FSM_MODE_SWinstead ofTOUCH_FSM_MODE_TIMERfor all Espressif. It seems to work fine.espressif/peripherals/touch.c.Tested on Feather Huzzah32 (ESP32), Feather ESP32 V2, Feather ESP32-S2, Feather ESP32-S3. (C3 does not have native touch.). I'd welcome other hands-on testing.